Bug fix Fragment::getUriComponent #31

thephpleague · Jan 18, 2016 · 667d64c · 667d64c
1 parent a851a6b
commit 667d64c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ All Notable changes to `League\Uri` will be documented in this file
 - Improve Uri Component modification [issue #29](https://github.com/thephpleague/uri/issues/29)
 - Improve Path encoding/decoding [issue #28](https://github.com/thephpleague/uri/issues/28)
 - Improve lowercase transformation in hostname [issue #27](https://github.com/thephpleague/uri/issues/27)
+- Bug when the fragment value is wrongly evaluated as empty [issue #31](https://github.com/thephpleague/uri/issues/31)
 
 ### Deprecated
 

diff --git a/src/Components/Fragment.php b/src/Components/Fragment.php
@@ -44,7 +44,7 @@ class Fragment extends AbstractComponent implements FragmentInterface
     public function getUriComponent()
     {
         $component = $this->__toString();
-        if (!empty($component)) {
+        if ('' !== $component) {
             $component = FragmentInterface::DELIMITER.$component;
         }
 

diff --git a/test/Components/FragmentTest.php b/test/Components/FragmentTest.php
@@ -27,6 +27,7 @@ public function validFragment()
         return [
             'null' => [null, ''],
             'empty' => ['', ''],
+            'evaluate empty' => ['0', '#0'],
             'hash'  => ['#', '#%23'],
             'toofan' => ['toofan', '#toofan'],
             'notencoded' => ["azAZ0-9/?-._~!$&'()*+,;=:@", '#azAZ0-9/?-._~!$&\'()*+,;=:@'],
@@ -50,7 +51,7 @@ public function failedConstructor()
             'bool'      => [true],
             'Std Class' => [(object) 'foo'],
             'float'     => [1.2],
-            'array'      => [['foo']],
+            'array'     => [['foo']],
         ];
     }
 }