Improve URL Encoding of Path Component

[mdawaffe]

The example at https://uri.thephpleague.com/uri/6.0/rfc3986/#uri-normalization shows how Uri::createFromString() can be used to normalize URLs:

$uri = Uri::createFromString(
    "hTTp://www.ExAmPLE.com:80/hello/./wor ld?who=f 3#title"
);
echo $uri; //displays http://www.example.com/hello/./wor%20ld?who=f%203#title

Unfortunately, the actual output is not the same as the documented output:

Documented

http://www.example.com/hello/./wor%20ld?who=f%203#title

Actual

http://www.example.com/hello/./wor ld?who=f%203#title

(Note the unencoded whitespace in the path component and the correctly encoded query component of the actual output.)

This is caused by some unwanted escaping in URI::formatPath()'s regex:

uri/src/Uri.php

Line 975 in 1d6a347

static $pattern = '/(?:[^'.self::REGEXP_CHARS_UNRESERVED.self::REGEXP_CHARS_SUBDELIM.'%:@\/}{]++\|%(?![A-Fa-f0-9]{2}))/';

(It should read | instead of \|.)

This PR corrects that regex and adds a test case.

Unfortunately, that regex change broke another test: one concerning a Windows path syntax I have not encountered before: C| instead of the more common C:. To fix that test, I've changed how Uri::formatFilePath() works, but, being unfamiliar with the syntax, I'm not sure if I've actually fixed the underlying problem or if I've just done enough to pass the existing tests. (Also, the changes I made there are a bit ugly :)).

[nyamsprod]

@mdawaffe Thanks for the PR ... at first glance I don't see any issue.
You can already add the fix in the CHANGELOG.md and don't forget to mention yourself 👍
Once this is done I'll merge the work and release the patch version 😉

[mdawaffe]

@nyamsprod, I took a shot at updating the changelog. I made up a date :) Please edit/reformat/whatever anything you want!

[nyamsprod]

Cool thanks again I'll merge this PR and try to release a patch version this weekend or worse case scenario next monday 👍

[mdawaffe]

Awesome - thanks!

[nyamsprod]

version 6.4.0 is released with your patch ... 💯 🎉

[mdawaffe]

Great - thanks!