Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tools: Clair, Snyk, Grype #15

Merged
merged 13 commits into from
Oct 4, 2024
Merged

Add new tools: Clair, Snyk, Grype #15

merged 13 commits into from
Oct 4, 2024

Conversation

reynico
Copy link
Contributor

@reynico reynico commented Oct 3, 2024

No description provided.

@reynico reynico requested a review from mattaereal October 3, 2024 20:01
@reynico reynico self-assigned this Oct 3, 2024
@reynico reynico closed this Oct 3, 2024
@reynico reynico reopened this Oct 3, 2024
mattaereal
mattaereal requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@mattaereal mattaereal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed grype and snyk differently. Tried to suggest small changes via gh's UI but horrible experience.

A few PRs after this I successfully installed them both las follows:
RUN pnpm install -g snyk
RUN curl -sSfL https://raw.githubusercontent.com/anchore/grype/main/install.sh | sudo sh -s -- -b /usr/local/bin

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
reynico and others added 6 commits October 3, 2024 20:51
@reynico @mattaereal
Update Dockerfile
8b47236 
Co-authored-by: Matías Aereal Aeón <388605+mattaereal@users.noreply.github.com>
@reynico @mattaereal
Update Dockerfile
f4f966c 
Co-authored-by: Matías Aereal Aeón <388605+mattaereal@users.noreply.github.com>
@reynico @mattaereal
Update Dockerfile
5386d11 
Co-authored-by: Matías Aereal Aeón <388605+mattaereal@users.noreply.github.com>
@reynico @mattaereal
Update Dockerfile
0e693c9 
Co-authored-by: Matías Aereal Aeón <388605+mattaereal@users.noreply.github.com>
@reynico @mattaereal
Update Dockerfile
b44bde6 
Co-authored-by: Matías Aereal Aeón <388605+mattaereal@users.noreply.github.com>
@reynico
dockerfile: remove unneeded script lines
32f6ac8
@reynico
Copy link
Contributor Author

reynico commented Oct 3, 2024

I installed grype and snyk differently. Tried to suggest small changes via gh's UI but horrible experience.

A few PRs after this I successfully installed them both las follows: RUN pnpm install -g snyk RUN curl -sSfL https://raw.githubusercontent.com/anchore/grype/main/install.sh | sudo sh -s -- -b /usr/local/bin

gotcha! just addressed the comments and committed a last fix to the suggestions. CI is passing as expected so I think this is good to go

@reynico reynico requested a review from mattaereal October 4, 2024 00:11
@mattaereal mattaereal merged commit 3456421 into develop Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattaereal mattaereal mattaereal approved these changes

Assignees

@reynico reynico

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reynico @mattaereal