feat: grpc-web support #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
grpc-web
branch
2 times, most recently
from
d176996 to
53044f2
Compare
Closed
|
any progress? |
|
@eyouyou I am going to put effort into this week. I made it work with a go server with rollup + typescript on the web. |
thesayyn
force-pushed
the
grpc-web
branch
4 times, most recently
from
0cb8f88 to
e6ca731
Compare
thesayyn
force-pushed
the
grpc-web
branch
3 times, most recently
from
1113e30 to
d7246b7
Compare
thesayyn
force-pushed
the
grpc-web
branch
15 times, most recently
from
9997868 to
8fca833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch for the initial support for the generation of grpc-web compatible clients.
protoc-gen-tsalways supported grpc-web but the generated source files that are generated throughprotoc-gen-grpc-webhave always required manual intervention such as replacing imports to useprotoc-gen-tscounterpart of generated pb.Currently, one has to change imports
require("./type_pb")withrequire("./type")With native support of grpc-web clients, one will only have to present
--ts_opt=target=webto generate grpc-web compatible clients instead of nodejs.web implementation supports the official
grpc-webimplementation. other implementations such as improbable-eng/grpc-web can be added later if there is community interest!supported RPC types are as follows;
closes #97