Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align FilterIterator::accept() method signatures #12

Closed
wants to merge 1 commit into from

Conversation

dereckson
Copy link

Fixes #11.

@theseer
Copy link
Owner

theseer commented May 9, 2022

While the proposed fix makes perfect sense, its syntax is not PHP 5.3.1 compliant ;)

The DirectoyScanner lib is rather old and is mainly on what I would call "life support" and I do not plan to make a new major release - which would be required when breaking BC with - granted - seriously outdated PHP versions.

Other than that: The attributes added by @jrfnl fix the PHP 8.1 deprecation warnings. That won't make a promise it will work with PHP 8.2 or later but that's a different story. But by then we'd probably archived this project...

Sorry.

@theseer theseer closed this May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1 signatures deprecation
2 participants