Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: implement TryInto for Value, Reference and Object #105

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added breaking enhancement New feature or request labels Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

🐰 Bencher Report

Branchimplement-try-into
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
24,349.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
29,054.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
26,660.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
53,189,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
50,789,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
54,299,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
37,328,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
21,478.00
to_string📈 view plot
⚠️ NO THRESHOLD
140,930.00
verify📈 view plot
⚠️ NO THRESHOLD
929.15
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 97.54098% with 33 lines in your changes missing coverage. Please review.

Project coverage is 96.55%. Comparing base (cc01cb6) to head (726030d).

Files with missing lines Patch % Lines
ristretto_classloader/src/value.rs 94.43% 23 Missing ⚠️
ristretto_cli/src/main.rs 0.00% 6 Missing ⚠️
...to_vm/src/native_methods/java_io_unixfilesystem.rs 0.00% 1 Missing ⚠️
...istretto_vm/src/native_methods/java_lang_system.rs 0.00% 1 Missing ⚠️
...istretto_vm/src/native_methods/java_lang_thread.rs 0.00% 1 Missing ⚠️
...ive_methods/jdk_internal_loader_nativelibraries.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   96.47%   96.55%   +0.07%     
==========================================
  Files         136      136              
  Lines       24255    25449    +1194     
==========================================
+ Hits        23401    24573    +1172     
- Misses        854      876      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman force-pushed the implement-try-into branch 3 times, most recently from 031c487 to 726030d Compare November 7, 2024 19:28
@brianheineman brianheineman merged commit cbfaeb6 into main Nov 7, 2024
66 checks passed
@brianheineman brianheineman deleted the implement-try-into branch November 7, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant