Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialize VM; call System.initPhase2() and System.initPhase3() #127

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Nov 14, 2024
Copy link

🐰 Bencher Report

Branchinitialize-vm
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
24,268.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
32,359.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
30,559.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
60,842,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
59,239,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
63,105,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
47,771,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
21,733.00
to_string📈 view plot
⚠️ NO THRESHOLD
187,460.00
verify📈 view plot
⚠️ NO THRESHOLD
930.41
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.19%. Comparing base (747ffc9) to head (bd55476).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ristretto_vm/src/vm.rs 72.72% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   96.10%   96.19%   +0.08%     
==========================================
  Files         143      144       +1     
  Lines       26793    26858      +65     
==========================================
+ Hits        25750    25836      +86     
+ Misses       1043     1022      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 977dfee into main Nov 14, 2024
68 of 69 checks passed
@brianheineman brianheineman deleted the initialize-vm branch November 14, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant