Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add java.lang.reflect.Array.newArray(Ljava/lang/Class;I)Ljava/lang/Object; #137

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Nov 20, 2024
Copy link

🐰 Bencher Report

Branchadd-array-new-array
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
26,620.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
31,557.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
28,314.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
61,373,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
61,216,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
55,273,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
42,678,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
22,371.00
to_string📈 view plot
⚠️ NO THRESHOLD
151,960.00
verify📈 view plot
⚠️ NO THRESHOLD
967.43
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 44.89796% with 27 lines in your changes missing coverage. Please review.

Project coverage is 95.80%. Comparing base (d539975) to head (5bbc809).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...o_vm/src/native_methods/java_lang_reflect_array.rs 25.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   95.89%   95.80%   -0.10%     
==========================================
  Files         145      146       +1     
  Lines       27140    27188      +48     
==========================================
+ Hits        26027    26048      +21     
- Misses       1113     1140      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@brianheineman brianheineman merged commit 0e62a9a into main Nov 20, 2024
67 of 69 checks passed
@brianheineman brianheineman deleted the add-array-new-array branch November 20, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant