fix: set String.hashIsZero to false when creating a new string in Java 17+ #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a 17+ Adjusted Java object string handling for Java 17+ compatibility. Updated multiple dependencies in Cargo.lock including syn to 2.0.89 and hyper to 1.5.1.
brianheineman
changed the title
|
Bencher Report| Branch | string-hash-is-zero |
| Testbed | localhost |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| from_bytes | 📈 view plot | 45,576.00 |
| load_hash_map | 📈 view plot | 36,032.00 |
| load_invalid_class | 📈 view plot | 27,193.00 |
| runtime_v11 | 📈 view plot | 33,710,000.00 |
| runtime_v17 | 📈 view plot | 30,489,000.00 |
| runtime_v21 | 📈 view plot | 32,162,000.00 |
| runtime_v8 | 📈 view plot | 21,857,000.00 |
| to_bytes | 📈 view plot | 22,561.00 |
| to_string | 📈 view plot | 150,830.00 |
| verify | 📈 view plot | 1,058.60 |
brianheineman
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 95.81% 95.81% -0.01%
==========================================
Files 147 147
Lines 27303 27307 +4
==========================================
+ Hits 26160 26163 +3
- Misses 1143 1144 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
String.hashIsZerotofalsewhen creating a new string in Java 17+.