Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct Java 8 string handling to encode Rust strings as UTF-16 #153

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Nov 28, 2024

  • correct Java 8 string handling to encode Rust strings as UTF-16
  • split strings on character instead of byte boundaries to support unicode

@github-actions github-actions bot added the fix label Nov 28, 2024
Copy link

🐰 Bencher Report

Branchcorrect-unicode-debug-support
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
25,992.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
30,050.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
27,545.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
31,739,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
29,733,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
31,617,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
22,116,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
22,250.00
to_string📈 view plot
⚠️ NO THRESHOLD
153,540.00
verify📈 view plot
⚠️ NO THRESHOLD
947.63
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.95%. Comparing base (289a4b8) to head (0d580a9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ristretto_vm/src/java_object.rs 0.00% 2 Missing ⚠️
ristretto_vm/src/local_variables.rs 50.00% 2 Missing ⚠️
ristretto_vm/src/operand_stack.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files         526      526           
  Lines       44876    44877    +1     
=======================================
+ Hits        34533    34535    +2     
+ Misses      10343    10342    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman changed the title fix: split strings on character instead of byte boundaries to support unicode fix: correct Java 8 string handling to encode Rust strings as UTF-16 Nov 28, 2024
@brianheineman brianheineman merged commit 09385a5 into main Nov 28, 2024
70 of 71 checks passed
@brianheineman brianheineman deleted the correct-unicode-debug-support branch November 28, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant