Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct errors with Java 11 initialization #154

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Nov 29, 2024
@brianheineman brianheineman force-pushed the fix-java11-initialization branch from 7540420 to 8501438 Compare November 29, 2024 17:30
Copy link

github-actions bot commented Nov 29, 2024

🐰 Bencher Report

Branchfix-java11-initialization
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
25,838.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
32,340.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
29,309.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
41,056,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
37,459,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
39,681,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
24,690,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
21,857.00
to_string📈 view plot
⚠️ NO THRESHOLD
166,930.00
verify📈 view plot
⚠️ NO THRESHOLD
1,013.50
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (09385a5) to head (8501438).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ristretto_vm/src/thread.rs 0.00% 6 Missing ⚠️
...to_vm/src/native_methods/java_io_filedescriptor.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   76.95%   78.00%   +1.05%     
==========================================
  Files         526      526              
  Lines       44877    44897      +20     
==========================================
+ Hits        34535    35023     +488     
+ Misses      10342     9874     -468     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 47021c9 into main Nov 29, 2024
68 checks passed
@brianheineman brianheineman deleted the fix-java11-initialization branch November 29, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant