Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct getCallerClass() to return null instead of void #159

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

🐰 Bencher Report

Branchcorrect-get-caller-class
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
26,601.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
33,330.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
30,032.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
34,617,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
36,001,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
36,100,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
24,085,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
21,239.00
to_string📈 view plot
⚠️ NO THRESHOLD
151,870.00
verify📈 view plot
⚠️ NO THRESHOLD
1,013.30
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (f55dad7) to head (4169d44).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
..._vm/src/native_methods/jdk_internal_misc_unsafe.rs 7.14% 13 Missing ⚠️
...to_vm/src/native_methods/sun_reflect_reflection.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   78.01%   78.01%   -0.01%     
==========================================
  Files         526      526              
  Lines       44897    44900       +3     
==========================================
  Hits        35027    35027              
- Misses       9870     9873       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 521711c into main Dec 2, 2024
68 of 69 checks passed
@brianheineman brianheineman deleted the correct-get-caller-class branch December 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant