Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement java.lang.ClassLoader methods #161

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

🐰 Bencher Report

Branchclassloader-impl
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
27,120.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
39,758.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
29,876.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
37,000,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
31,240,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
37,056,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
23,072,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
20,842.00
to_string📈 view plot
⚠️ NO THRESHOLD
136,220.00
verify📈 view plot
⚠️ NO THRESHOLD
1,007.10
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 147 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (bfb5ec9) to head (e628ceb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...tto_vm/src/native_methods/java_lang_classloader.rs 0.78% 126 Missing ⚠️
ristretto_vm/src/native_methods/java_lang_class.rs 8.69% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   77.99%   77.83%   -0.17%     
==========================================
  Files         526      526              
  Lines       44911    45026     +115     
==========================================
+ Hits        35029    35044      +15     
- Misses       9882     9982     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit be18244 into main Dec 4, 2024
67 of 69 checks passed
@brianheineman brianheineman deleted the classloader-impl branch December 4, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant