Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement numerous jdk.internal.misc.Unsafe get<type>() and put<type>() methods #171

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

🐰 Bencher Report

Branchimpl-unsafe-methods
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
25,875.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
28,873.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
26,516.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
30,644,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
28,890,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
30,646,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
20,186,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
19,806.00
to_string📈 view plot
⚠️ NO THRESHOLD
127,850.00
verify📈 view plot
⚠️ NO THRESHOLD
927.44
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 4.21053% with 91 lines in your changes missing coverage. Please review.

Project coverage is 77.64%. Comparing base (22a6900) to head (b572049).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
..._vm/src/native_methods/jdk/internal/misc/unsafe.rs 4.21% 91 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   77.72%   77.64%   -0.09%     
==========================================
  Files         526      526              
  Lines       45163    45210      +47     
==========================================
  Hits        35103    35103              
- Misses      10060    10107      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit fc4d38f into main Dec 5, 2024
67 of 69 checks passed
@brianheineman brianheineman deleted the impl-unsafe-methods branch December 5, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant