Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct exception handling class check #182

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

🐰 Bencher Report

Branchcorrect-exception-hanlding
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
26,127.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
29,544.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
28,564.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
30,196,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
27,805,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
30,518,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
19,201,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
20,594.00
to_string📈 view plot
⚠️ NO THRESHOLD
124,930.00
verify📈 view plot
⚠️ NO THRESHOLD
947.99
🐰 View full continuous benchmarking report in Bencher

@brianheineman brianheineman merged commit 36f260f into main Dec 7, 2024
67 checks passed
@brianheineman brianheineman deleted the correct-exception-hanlding branch December 7, 2024 17:17
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.06%. Comparing base (6145f8d) to head (f954523).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ristretto_vm/src/instruction/exception.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   76.06%   76.06%           
=======================================
  Files         527      527           
  Lines       46585    46585           
=======================================
  Hits        35433    35433           
  Misses      11152    11152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant