Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: conditionally register macos native functions #191

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the build label Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

🐰 Bencher Report

Branchcfg-macos-methods
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
26,090.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
531.30
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
27,229.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
5,532,100.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
6,765,800.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
7,181,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
20,176,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
20,244.00
to_string📈 view plot
⚠️ NO THRESHOLD
124,570.00
verify📈 view plot
⚠️ NO THRESHOLD
922.35
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.76%. Comparing base (bf7982e) to head (2ca0b54).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
ristretto_vm/src/native_methods/registry.rs 42.85% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   76.01%   72.76%   -3.26%     
==========================================
  Files         527      527              
  Lines       46627    46585      -42     
==========================================
- Hits        35445    33899    -1546     
- Misses      11182    12686    +1504     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 0267b7e into main Dec 11, 2024
66 of 68 checks passed
@brianheineman brianheineman deleted the cfg-macos-methods branch December 11, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant