Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement java.lang.Class.getDeclaredClasses0()[Ljava/lang/Class; #211

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Jan 11, 2025
Copy link
Contributor

🐰 Bencher Report

Branchimpl-class-get-declared-classes
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
24,652.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
398.02
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
29,598.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
7,716,400.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
8,958,200.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
9,817,500.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
25,311,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
19,904.00
to_string📈 view plot
⚠️ NO THRESHOLD
139,690.00
verify📈 view plot
⚠️ NO THRESHOLD
1,013.60
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 72.78%. Comparing base (67d523b) to head (aca3edb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ristretto_vm/src/native_methods/java/lang/class.rs 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   72.83%   72.78%   -0.06%     
==========================================
  Files         530      530              
  Lines       47441    47475      +34     
==========================================
  Hits        34553    34553              
- Misses      12888    12922      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 065d10f into main Jan 11, 2025
68 of 70 checks passed
@brianheineman brianheineman deleted the impl-class-get-declared-classes branch January 11, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant