Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary clone() for Value::TryInto and Reference::TryInto #224

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

brianheineman
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Jan 20, 2025

🐰 Bencher Report

Branchremove-tryinto-clone
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
33,122.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
529.50
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
31,999.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
8,085,800.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
11,016,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
11,448,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
23,841,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
24,898.00
to_string📈 view plot
⚠️ NO THRESHOLD
166,920.00
verify📈 view plot
⚠️ NO THRESHOLD
1,232.70
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.75%. Comparing base (5bdfce6) to head (e809721).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   96.67%   96.75%   +0.07%     
==========================================
  Files         530      530              
  Lines       58371    58449      +78     
==========================================
+ Hits        56433    56550     +117     
+ Misses       1938     1899      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 9799c75 into main Jan 20, 2025
69 checks passed
@brianheineman brianheineman deleted the remove-tryinto-clone branch January 20, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant