Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement java.lang.System.mapLibraryName() #60

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Oct 14, 2024
Copy link

🐰 Bencher Report

Branchimplement-java-lang-system-maplibraryname
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
34,526.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
33,374.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
27,655.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
66,111,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
57,774,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
66,670,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
45,092,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
23,484.00
to_string📈 view plot
⚠️ NO THRESHOLD
186,210.00
verify📈 view plot
⚠️ NO THRESHOLD
1,011.30
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 26 lines in your changes missing coverage. Please review.

Project coverage is 96.36%. Comparing base (ed4ff17) to head (4caa152).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...istretto_vm/src/native_methods/java_lang_system.rs 26.08% 17 Missing ⚠️
...c/native_methods/jdk_internal_loader_bootloader.rs 50.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   96.47%   96.36%   -0.11%     
==========================================
  Files         122      123       +1     
  Lines       22690    22732      +42     
==========================================
+ Hits        21890    21906      +16     
- Misses        800      826      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 66f713c into main Oct 14, 2024
65 of 67 checks passed
@brianheineman brianheineman deleted the implement-java-lang-system-maplibraryname branch October 14, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant