Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename VM.class() to VM.load_class() and VM.load() to VM.class() #68

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

Copy link

🐰 Bencher Report

Branchrefactor-vm-class-functions
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
26,063.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
29,256.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
26,755.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
58,004,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
52,045,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
54,751,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
39,601,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
22,254.00
to_string📈 view plot
⚠️ NO THRESHOLD
144,130.00
verify📈 view plot
⚠️ NO THRESHOLD
1,004.50
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.02%. Comparing base (e54ddcf) to head (ffcd575).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...retto_vm/src/native_methods/java_lang_throwable.rs 0.00% 3 Missing ⚠️
ristretto_cli/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   96.03%   96.02%   -0.01%     
==========================================
  Files         124      124              
  Lines       22949    22951       +2     
==========================================
  Hits        22039    22039              
- Misses        910      912       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit fe5d6c9 into main Oct 15, 2024
68 of 69 checks passed
@brianheineman brianheineman deleted the refactor-vm-class-functions branch October 15, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant