Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename RuntimeError to InternalError #70

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Oct 15, 2024

🐰 Bencher Report

Branchrename-runtime-error-to-internal-error
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
25,143.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
34,474.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
27,869.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
52,284,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
53,665,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
68,829,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
37,663,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
21,870.00
to_string📈 view plot
⚠️ NO THRESHOLD
137,200.00
verify📈 view plot
⚠️ NO THRESHOLD
955.78
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 5.45455% with 52 lines in your changes missing coverage. Please review.

Project coverage is 95.96%. Comparing base (e35507c) to head (9a516aa).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
..._vm/src/native_methods/jdk_internal_misc_unsafe.rs 0.00% 11 Missing ⚠️
..._vm/src/native_methods/java_io_fileoutputstream.rs 22.22% 7 Missing ⚠️
ristretto_vm/src/native_methods/java_lang_class.rs 0.00% 7 Missing ⚠️
...istretto_vm/src/native_methods/java_lang_system.rs 0.00% 7 Missing ⚠️
...ative_methods/jdk_internal_util_systemprops_raw.rs 0.00% 5 Missing ⚠️
.../src/native_methods/java_lang_stacktraceelement.rs 0.00% 3 Missing ⚠️
ristretto_cli/src/main.rs 0.00% 2 Missing ⚠️
ristretto_vm/src/call_stack.rs 0.00% 2 Missing ⚠️
ristretto_vm/src/instruction/invoke.rs 0.00% 2 Missing ⚠️
...istretto_vm/src/native_methods/java_lang_object.rs 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   95.97%   95.96%   -0.01%     
==========================================
  Files         125      125              
  Lines       22973    22975       +2     
==========================================
  Hits        22049    22049              
- Misses        924      926       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit d18f66c into main Oct 15, 2024
67 of 68 checks passed
@brianheineman brianheineman deleted the rename-runtime-error-to-internal-error branch October 15, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant