Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement jdk.internal.loader.NativeLibraries.findBuiltinLib() #83

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Oct 20, 2024
Copy link
Contributor

🐰 Bencher Report

Branchimplement-nativelibraries-findbuiltinlib
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
23,890.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
29,912.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
27,072.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
53,417,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
51,100,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
53,643,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
36,881,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
21,192.00
to_string📈 view plot
⚠️ NO THRESHOLD
136,740.00
verify📈 view plot
⚠️ NO THRESHOLD
921.57
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 96.29%. Comparing base (440c692) to head (af043c2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ive_methods/jdk_internal_loader_nativelibraries.rs 30.00% 21 Missing ⚠️
...istretto_vm/src/native_methods/java_lang_system.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   96.38%   96.29%   -0.10%     
==========================================
  Files         126      127       +1     
  Lines       23536    23570      +34     
==========================================
+ Hits        22686    22696      +10     
- Misses        850      874      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 3b8fc45 into main Oct 20, 2024
67 of 69 checks passed
@brianheineman brianheineman deleted the implement-nativelibraries-findbuiltinlib branch October 20, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant