Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add environment variable support #98

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 1, 2024

🐰 Bencher Report

Branchadd-environment-variable-support
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
25,505.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
29,598.00
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
27,305.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
53,597,000.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
51,200,000.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
55,456,000.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
37,611,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
21,887.00
to_string📈 view plot
⚠️ NO THRESHOLD
139,570.00
verify📈 view plot
⚠️ NO THRESHOLD
928.07
🐰 View full continuous benchmarking report in Bencher

@github-actions github-actions bot added the enhancement New feature or request label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 96.28866% with 18 lines in your changes missing coverage. Please review.

Project coverage is 96.62%. Comparing base (7f3a5ab) to head (1d07c59).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...src/native_methods/java_lang_processenvironment.rs 23.52% 13 Missing ⚠️
...tto_vm/src/native_methods/java_lang_processimpl.rs 57.14% 3 Missing ⚠️
ristretto_vm/src/vm.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   96.63%   96.62%   -0.02%     
==========================================
  Files         129      131       +2     
  Lines       23677    24034     +357     
==========================================
+ Hits        22881    23223     +342     
- Misses        796      811      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 8f29565 into main Nov 1, 2024
68 of 69 checks passed
@brianheineman brianheineman deleted the add-environment-variable-support branch November 1, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant