Implement embeds by issueId #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes This implements a new feature to embed linear links based off of the `issueId` if it's placed in a message, such as `THESIS-123`. Additionally this adds a function to delete the embed if the original message link is deleted / changed. Still need to implement editing the original embed if it changes.
Shadowfiend
reviewed
Nov 26, 2024
This will now pull in the issue tags dynamically from the Linear API rather than having to define it in `ISSUE_PREFIXES`
Let's switch the `robot.logger.info` into `robot.logger.debug`
This adds support for editing the embeds if the original message is updated with changed issues. Ready to roll out for testing. Adds support to `issueTagRegex` for different cased issues like `iSsUe-111` or `ISSUE-111`
|
Calling this one ready for review/merge. There is likely some edge cases to resolve but I suppose we can iterate further! I've implemented editing embeds and also grabbing issue |
Shadowfiend
reviewed
Dec 3, 2024
Shadowfiend
reviewed
Dec 3, 2024
Shadowfiend
reviewed
Dec 3, 2024
| const embedPromises = matches.map(async (match) => { | ||
| const uniqueMatches = new Set<string>() | ||
|
|
||
| urlMatches.forEach((match) => { | ||
| const teamName = match[1] |
There was a problem hiding this comment.
Note for all of these you can use named capturing groups.
Shadowfiend
reviewed
Dec 3, 2024
Shadowfiend
reviewed
Dec 3, 2024
This resolves the issues with excessive json calls and fixing up the regex patterns as per review!
Shadowfiend
reviewed
Dec 4, 2024
|
|
||
| function initializeIssueTagRegex() { | ||
| issueTagRegex = | ||
| /(?<!https:\/\/linear\.app\/[a-zA-Z0-9-]+\/issue\/)[A-Z]{3,}-\d+\b/gi |
There was a problem hiding this comment.
At this point we can just put this in a const rather than initializing, right?
Shadowfiend
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This implements a new feature to embed linear links based off of the
issueIdif it's placed in a message, such asTHESIS-123.Additionally this adds a function to delete the embed if the original message link is deleted / changed.
Still need to implement editing the original embed if it changes.