Thread decision fixes #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes This resolves a few issues with the thread decisions: - Let's make sure when an interaction is pressed. the text output corresponds to that action (i.e status update) - We edit the original interaction to remove the buttons when clicked as well as marked with the action taken, and by who.
This adds the threads `autoArchiveDuration` to the messages triggered by the interactions as well as setting the nickname instead of tagging the user.
This changes the flow so that we remove the original button interaction when an action is taken then also send that in a message to the decision taker with a nickname from the person who made the interaction.
Shadowfiend
reviewed
Dec 5, 2024
| return user.username | ||
| } | ||
| const member = await guild.members.fetch(user.id) | ||
| return member.nickname || user.username |
There was a problem hiding this comment.
Suggested change
| return member.nickname || user.username | |
| return member.nickname ?? user.username |
Shadowfiend
reviewed
Dec 5, 2024
| @@ -63,7 +78,7 @@ function requestFollowUpAction( | |||
| .followUp({ | |||
| content: `Thanks ${userMention( | |||
There was a problem hiding this comment.
Let's drop the user mention here, since you're just mentioning yourself?
Shadowfiend
reviewed
Dec 5, 2024
| @@ -63,7 +78,7 @@ function requestFollowUpAction( | |||
| .followUp({ | |||
| content: `Thanks ${userMention( | |||
| requestingUserId, | |||
| )}, please ${requestedAction} this thread or it will be archived in 24 hours ❤️`, | |||
| )}, please ${requestedAction} this thread or it will be archived in <t:${followUpDeadline}:F> (<t:${followUpDeadline}:R> ❤️)`, | |||
There was a problem hiding this comment.
Suggested change
| )}, please ${requestedAction} this thread or it will be archived in <t:${followUpDeadline}:F> (<t:${followUpDeadline}:R> ❤️)`, | |
| )}, please ${requestedAction} this thread or it will be archived in <t:${followUpDeadline}:F> (<t:${followUpDeadline}:R>) ❤️`, |
Shadowfiend
reviewed
Dec 5, 2024
|
|
||
| await interaction.message.edit({ | ||
| content: `${interaction.message.content}\n\n☑️ **Archived** by ${nickname}`, | ||
| components: [], |
There was a problem hiding this comment.
Does sending this interaction unarchive the thread?
Shadowfiend
reviewed
Dec 5, 2024
| @@ -189,9 +211,11 @@ const threadActions: { | |||
| thread, | |||
| interaction, | |||
| interaction.member, | |||
| "capture the task(s) associated with", | |||
| "post a status associated with", | |||
Shadowfiend
reviewed
Dec 5, 2024
| @@ -234,9 +257,11 @@ const threadActions: { | |||
| thread, | |||
| interaction, | |||
| interaction.member, | |||
| "capture the task(s) associated with", | |||
| "make a decision for", | |||
Shadowfiend
reviewed
Dec 5, 2024
| userIdToTag, | ||
| ) | ||
|
|
||
| await interaction.message.delete() |
There was a problem hiding this comment.
If we always delete the interaction message, should we do it in the caller?
Shadowfiend
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This resolves a few issues with the thread decisions: