Fix tests for build environment relying on PYTHONPATH
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
reviewed
Apr 29, 2021
befeleme
force-pushed
the
copy-existing-env
branch
2 times, most recently
from
d9fae2a to
13303ca
Compare
|
Thanks for the suggestion, fixed. |
hartwork
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Very nice, I was about to push the same thing for Gentoo 👍
The missing variable is PYTHONPATH: Without it setuptools easy-install-entry-script will happily use (say) dotenv 0.16.0 installed in the system rather than 0.17.0 in those two tests. So my vote for merging this before the next release. Thank you! 🙏
Related:
|
PS: @befeleme could you adjust the title of the pull request to make clear that this is a bugfix for the tests? Thank you! |
Overriding the whole environment would remove critical variables like `PYTHONPATH`. This would break tests on some systems like during Fedora or Gentoo packaging.
bbc2
changed the title
PYTHONPATH
|
Thank you for the fix! I just fixed some formatting and updated the changelog. I'll release this in a few minutes. |
|
Released as v0.17.1. |
|
Very nice, thank you! 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I want to update dotenv to 0.17.0 in Fedora, but realized the two newly introduced tests started failing in the build process.
This happens because defining
_envreplaces the existing environment, effectively unsetting many variables (which, in my case, means losing information where to look for the module to import). Instead of creating completely new contents, I propose copying existing environment and adding the tested key-value on the top of it.This will not affect the existing test suite but can help other packagers.