Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.5 and 3.6 and upgrade GA #393

Merged
merged 6 commits into from
Jul 23, 2022
Merged

Drop Python 3.5 and 3.6 and upgrade GA #393

merged 6 commits into from
Jul 23, 2022

Conversation

eggplants
Copy link
Contributor

@eggplants eggplants commented Mar 31, 2022 •
edited by theskumar
Loading

Closes: #392
Closes: #412

@theskumar
Copy link
Owner

@eggplants The tests are failing. Would it be possible for you to review them?

@eggplants
Copy link
Contributor Author

Test seems to fail due to significant coverage reduction.
Miss:47/Stmts:154, Cover:89% -> Miss:274/Stmts:359, Cover:24%
I will look into the cause and correct it.

@theskumar theskumar changed the title Drop Python 3.5 and 3.6 Drop Python 3.5 and 3.6 and upgrade GA Jul 23, 2022
@theskumar theskumar merged commit 2f36c08 into theskumar:master Jul 23, 2022
@eggplants eggplants deleted the drop_3.6 branch July 23, 2022 10:44
@iloveitaly iloveitaly mentioned this pull request Oct 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Python 3.6
2 participants
@eggplants @theskumar