Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASoC: SOF: Intel: hda-dai: Drop call to hda_link_dma_cleanup in dai_s… #5049

Closed
wants to merge 1 commit into from
Closed

ASoC: SOF: Intel: hda-dai: Drop call to hda_link_dma_cleanup in dai_s… #5049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions sound/soc/sof/intel/hda-dai.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,12 +617,6 @@ static int hda_dai_suspend(struct hdac_bus *bus)
sdai = swidget->private;
ops = sdai->platform_private;

ret = hda_link_dma_cleanup(hext_stream->link_substream,
hext_stream,
cpu_dai);
if (ret < 0)
return ret;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to contradict the comments line 599-602, and it's not clear why this causes a hard lockup?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, something is not right for sure, but it prevents the lockup.
If we suspend with active audio we run through the pre_trigger/trigger/post_trigger sequence (and SUSPEND/STOP/PAUSE_PUSH is identical up to post_trigger) then we call hda_link_dma_cleanup().

With the suspend while paused we just have a longer delay between the triggers and the hda_link_dma_cleanup()

But, we have failing FE triggers, so we might fail to stop host side and this has some side effect on the link side if it is cleaned?
We cannot see this as the system is hard locked..

/* for consistency with TRIGGER_SUSPEND */
if (ops->post_trigger) {
ret = ops->post_trigger(sdev, cpu_dai,
Expand Down
Loading