Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] zep PR soc/intel_adsp: Correct linker syntax for ancient binutils #38374 #4728

Closed
wants to merge 2 commits into from

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Sep 7, 2021

(NOT!) Testing zephyrproject-rtos/zephyr#38374 tentative fix for XCC regression zephyrproject-rtos/zephyr#38349

@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 7, 2021

Just realized that manually git fetching in scripts/xtensa-build-zephyr.sh likes this does not work because our CI can't stop copying/pasting/diverging the build scripts. So it has an almost identical copy of that part of the script that clones Zephyr. Bummer.

EDIT: I have a solution to de-duplicate the CI code that clones Zephyr but it's based on (unrelated) #4733 which I submitted first.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 7, 2021

Even worse: the XCC failures (_without zephyrproject-rtos/zephyr#38374 because the manual git fetch is not run) are not what I expected: https://sof-ci.01.org/sofpr/PR4728/build10227/build

EDIT: the full build log with the actual build errors (and not just minor and irrelevant warnings) can be found at https://sof-ci.01.org/sofpr/PR4728/build10229/build/tgl-h_zph.txt

[125/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/drivers/intel/dmic/dmic_computed.c.obj
[126/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/drivers/intel/hda/hda-dma.c.obj
[127/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/platform/intel/cavs/lib/dma.c.obj
[128/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/drivers/intel/ssp/ssp.c.obj
/srv/home/jenkins/workspace/sof_generic_build/src/drivers/intel/ssp/ssp.c: In function ‘ssp_set_config_tplg’:
/srv/home/jenkins/workspace/sof_generic_build/src/drivers/intel/ssp/ssp.c:763: warning: too many arguments for format
[129/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/platform/intel/cavs/platform.c.obj
[130/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/platform/cannonlake/lib/clk.c.obj
[131/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/platform/intel/cavs/lib/clk.c.obj
[132/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/platform/intel/cavs/lib/dai.c.obj
[133/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/platform/intel/cavs/lib/pm_runtime.c.obj
--
[228/254] Building C object zephyr/kernel/CMakeFiles/kernel.dir/sem.c.obj
[229/254] Building C object zephyr/kernel/CMakeFiles/kernel.dir/system_work_q.c.obj
[230/254] Building C object zephyr/kernel/CMakeFiles/kernel.dir/stack.c.obj
[231/254] Building C object zephyr/kernel/CMakeFiles/kernel.dir/work.c.obj
[232/254] Building C object zephyr/kernel/CMakeFiles/kernel.dir/sched.c.obj
/srv/home/jenkins/workspace/sof_generic_build/zephyrproject/zephyr/kernel/sched.c:641: warning: C99 inline functions are not supported; using GNU89
/srv/home/jenkins/workspace/sof_generic_build/zephyrproject/zephyr/kernel/sched.c:641: warning: to disable this warning use -fgnu89-inline or the gnu_inline function attribute
/srv/home/jenkins/workspace/sof_generic_build/zephyrproject/zephyr/kernel/sched.c:931: warning: C99 inline functions are not supported; using GNU89
/srv/home/jenkins/workspace/sof_generic_build/zephyrproject/zephyr/include/kernel/sched_priq.h:36: warning: ‘z_priq_dumb_add’ declared inline after being called
/srv/home/jenkins/workspace/sof_generic_build/zephyrproject/zephyr/include/kernel/sched_priq.h:36: warning: previous declaration of ‘z_priq_dumb_add’ was here
/srv/home/jenkins/workspace/sof_generic_build/zephyrproject/zephyr/kernel/sched.c:1037: warning: C99 inline functions are not supported; using GNU89
/srv/home/jenkins/workspace/sof_generic_build/zephyrproject/zephyr/kernel/sched.c:1045: warning: C99 inline functions are not supported; using GNU89
[233/254] Building C object zephyr/kernel/CMakeFiles/kernel.dir/smp.c.obj
[234/254] Building C object zephyr/kernel/CMakeFiles/kernel.dir/condvar.c.obj
[235/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/samples/audio/smart_amp_test.c.obj
[236/254] Building C object modules/sof/CMakeFiles/modules_sof.dir/srv/home/jenkins/workspace/sof_generic_build/src/audio/src/src.c.obj
[237/254] Building C object zephyr/kernel/CMakeFiles/kernel.dir/timeout.c.obj

@marc-hb marc-hb changed the title [DNM] zep PR soc/intel_adsp: Correct linker syntax for ancient binutils #38374 [TEST] zep PR soc/intel_adsp: Correct linker syntax for ancient binutils #38374 Sep 7, 2021
@marc-hb marc-hb closed this Sep 8, 2021
@marc-hb marc-hb deleted the test-andy-xcc-fix branch September 9, 2021 00:20
marc-hb added a commit to marc-hb/sof that referenced this pull request Sep 9, 2021
This is needed by CI to clone only once and then take control of the
iteration over platform builds. CI already does all that but by
copy/paste/diverge of this clone() function.

Once cloning Zephyr in CI code is de-duplicated and uses this new
clone-only feature instead, it will be possible to submit any Zephyr
commit to SOF testing.  In other words it will make failed attempt
thesofproject#4728 possible

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Sep 9, 2021

Just realized that manually git fetching in scripts/xtensa-build-zephyr.sh likes this does not work because our CI can't stop copying/pasting/diverging the build scripts. So it has an almost identical copy of that part of the script that clones Zephyr. Bummer.

Fix part 1/2 submitted in #4740

lgirdwood pushed a commit that referenced this pull request Sep 10, 2021
This is needed by CI to clone only once and then take control of the
iteration over platform builds. CI already does all that but by
copy/paste/diverge of this clone() function.

Once cloning Zephyr in CI code is de-duplicated and uses this new
clone-only feature instead, it will be possible to submit any Zephyr
commit to SOF testing.  In other words it will make failed attempt
#4728 possible

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant