-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lmdk: dwmix: Add example of loadable down mixer module #8546
Conversation
Ported additional error code definitions from iadk module API. These codes are not unique and their meaning depends on the context / which function returns it. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
The example of down mixer module ported from iadk. Its build as a native loadable sof module. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
The API version used by the module is defined in the module api version header file. The definitions in CMakeLists.txt are no longer needed. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
} | ||
|
||
frames_processed = 0; | ||
while (frames_processed < frames_to_process) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm struggling with that frames processing. For an outsider it is a bit complex and without knowing how pipelines work looks like magic. @marcinszkudlinski do we have any docs for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use the same module code regardless of built-in baseFW or library module.
#define ADSP_MAX_VALUE ADSP_FATAL_FAILURE | ||
|
||
/* SystemAgentInterface */ | ||
#define ADSP_MODULE_CREATION_FAILURE (ADSP_MAX_VALUE + 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wont the max value be changed here if we add more errors ?
@@ -0,0 +1,520 @@ | |||
// SPDX-License-Identifier: BSD-3-Clause |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not duplicate the module sources in the code base, we should use the same module code regardless of basefw or module/library build.
Closing PR as we need to use the same module code for built-in and loadable module. |
This PR adds the example of down mixer module ported from iadk. Its build as a native loadable sof module.
Ported additional error code definitions from iadk module API. These codes are not unique and their meaning depends on the context / which function returns it.