Fix building of native loadable modules #8795
Conversation
softwarecki
requested review from
lgirdwood,
abonislawski,
kv2019i,
marcinszkudlinski,
jxstelter,
pjdobrowolski and
tmleman
softwarecki
requested review from
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
This commit reverts changes in:
src/module/audio/sink_api.c
src/module/audio/source_api.c
made by commit 12d958a. These changes made
it impossible to build native loadable modules.
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
There was a problem hiding this comment.
Where does this fail? I'm good to merge, but I need to understand where the failure is seen. These files are part of the basefw build:
xt-nm ../build-tgl/zephyr/zephyr.elf |grep source_get_
So the dependency to rtos/symbol.h seems correct.
If there is some non-basefw build that also compilers these files, then the offending lines should be #ifdef'ed out but in the base SOF build, these are ok.
|
Native loadable modules are building without Zephyr and they are not finding zephyr headers under define. |
|
You are right. That is our fault that building native modules is not in CI to block such changes however it blocks us to add it now. |
|
@pjdobrowolski wrote:
But this is not module code, this is basefw, which makes this confusing. If I build up-down-mixer with lmdk, these files dont' need to be compiled, right? If this gets compiled with lmdk, toget forward, can you add a ifdef around these lines. ifdef LMDK build, do not export the symbols. Basefw should build and be free to use native Zephyr services. |
can you just put around those things and be done with it |
|
Let me try and summarize - stand alone module build (without SOF base FW repo or Zephyr repo or maybe both ?) is failing as it has some undefined macros/functions ? |
@lgirdwood I don't think it depends on whether the build is stand-alone or with a base firmware build available. In fact I still think that isolated builds (not using a base FW build environment) aren't a good idea. But in any case, I think the reason here is simply, that "native system-service modules" link with these files, effectively they make a copy of them, in addition to those files being also linked with the base firmware. |
|
@lyakh @kv2019i @lgirdwood This files are shared between basefw and lmdk modules. Its contains common helper functions to handle sink/source interface. |
@lyakh can you create PR with it? |
|
@softwarecki Can you please add better description to this patch. This needs to explain WHY previous patch needs to be reverted. What is the error and how does this patch fixes it. |
This PR reverts changes in:
src/module/audio/sink_api.c
src/module/audio/source_api.c
made by commit 12d958a. These changes made it impossible to build native loadable modules.