tools: mtrace-reader.py: Add option to mark chunk starts in output #9520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it can help to see how the chunks arrive from firmware when comparing logs with the kernel for example. The --mark-chunks flag will add a marker for each new chunk that is printed with a running number and the size of the given chunk, for example: --- Chunk thesofproject#604 start (size: 652) --- [ 0.000000] <inf> init: print_version_banner: FW ABI 0x301d001 DBG ABI 0x5003000 tags SOF:v2.5-stable-branch-2772-g76e650e56598-dirty zephyr:v3.7.0-2127-ge7c84756087f src hash 0x4ff3fd64 (ref hash 0x4ff3fd64) *** Booting Zephyr OS build v3.7.0-2127-ge7c84756087f *** [ 0.000000] <inf> main: sof_app_main: SOF on intel_adsp [ 0.000000] <inf> main: sof_app_main: SOF initialized [ 0.000000] <inf> ipc: ipc_cmd: rx : 0x44000000|0x31400008 [11896.403666] <inf> ipc: ipc_cmd: tx-reply : 0x64000000|0x31400008 [11896.404076] <inf> ipc: ipc_cmd: rx : 0x44000000|0x3060004c [11896.404093] <inf> ipc: ipc_cmd: tx-reply : 0x64000000|0x3060004c --- Chunk thesofproject#605 start (size: 196) --- [11896.969658] <inf> ipc: ipc_cmd: rx : 0x11000005|0x0 [11896.969671] <inf> pipe: pipeline_new: pipeline new pipe_id 0 priority 0 [11896.969685] <inf> ipc: ipc_cmd: tx-reply : 0xb1000000|0x0 --- Chunk thesofproject#606 start (size: 2236) --- Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lgirdwood
approved these changes
Sep 27, 2024
kv2019i
approved these changes
Oct 1, 2024
| sys.stdout.write(chunk_msg) | ||
|
|
||
| sys.stdout.buffer.write(data) | ||
| sys.stdout.flush() |
There was a problem hiding this comment.
@ujfalusi Paused for a moment on this. Not sure if this disables the buffering compared to old version, but I guess the flush is needed in practise here as the buffer.write() is used. Let's merge this version and return if this causes problems.
|
Unrelated CI fails, proceeding to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it can help to see how the chunks arrive from firmware when comparing logs with the kernel for example.
The --mark-chunks flag will add a marker for each new chunk that is printed with a running number and the size of the given chunk, for example:
--- Chunk #604 start (size: 652) ---
[ 0.000000] init: print_version_banner: FW ABI 0x301d001 DBG ABI 0x5003000 tags SOF:v2.5-stable-branch-2772-g76e650e56598-dirty zephyr:v3.7.0-2127-ge7c84756087f src hash 0x4ff3fd64 (ref hash 0x4ff3fd64)
*** Booting Zephyr OS build v3.7.0-2127-ge7c84756087f ***
[ 0.000000] main: sof_app_main: SOF on intel_adsp
[ 0.000000] main: sof_app_main: SOF initialized
[ 0.000000] ipc: ipc_cmd: rx : 0x44000000|0x31400008
[11896.403666] ipc: ipc_cmd: tx-reply : 0x64000000|0x31400008
[11896.404076] ipc: ipc_cmd: rx : 0x44000000|0x3060004c
[11896.404093] ipc: ipc_cmd: tx-reply : 0x64000000|0x3060004c
--- Chunk #605 start (size: 196) ---
[11896.969658] ipc: ipc_cmd: rx : 0x11000005|0x0
[11896.969671] pipe: pipeline_new: pipeline new pipe_id 0 priority 0
[11896.969685] ipc: ipc_cmd: tx-reply : 0xb1000000|0x0
--- Chunk #606 start (size: 2236) ---