batch actions #68
Open
batch actions #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| else: | ||
| driver_fn(sight) | ||
|
|
||
| decision_messages = get_decision_messages_from_proto( |
There was a problem hiding this comment.
run() is getting long. Please pull this region (e.g. the while (True) stuff that does the actual work) into a separate function
| def get_decision_outcome_proto_from_cached(outcome_label: str, | ||
| decision_message: DecisionMessage): | ||
|
|
||
| logging.info('decision message =>%s', decision_message) |
There was a problem hiding this comment.
add function comments, remove logging statement (will be very noisy)
| def _configure_client_and_worker(sight): | ||
| """Configures the client and worker identifiers.""" | ||
| if FLAGS.deployment_mode in ["local"] or _TRAINED_MODEL_LOG_ID.value: | ||
| global _sight_id |
There was a problem hiding this comment.
Do we need this global _sight_id variable? It breaks modularity and I don't see it being used anywhere.
| outcome_params: Optional[dict] = None | ||
|
|
||
|
|
||
| class CachedBatchMessages: |
|
|
||
|
|
||
| class CachedBatchMessages: | ||
| _instance = None # Class-level variable for the singleton instance |
There was a problem hiding this comment.
To allow for this class to be used from multiple threads or multiple Sight objects it would be more modular to keep explicit references to CachedBatchMessages objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.