fix: fix IsTopLevelManifest calculation for versioned manifests #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
asraa
changed the title
znewman01
previously approved these changes
Sep 9, 2022
asraa
force-pushed
the
fix-role-calculation
branch
from
d3bbcdc to
c09ffd9
Compare
Signed-off-by: Asra Ali <asraa@google.com> oops Signed-off-by: Asra Ali <asraa@google.com> lint Signed-off-by: Asra Ali <asraa@google.com>
asraa
force-pushed
the
fix-role-calculation
branch
from
c09ffd9 to
dc75e91
Compare
znewman01
previously approved these changes
Sep 12, 2022
Yes, only because I re-use the |
znewman01
approved these changes
Sep 12, 2022
mnm678
approved these changes
Sep 12, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Please fill in the fields below to submit a pull request. The more information that is provided, the better.
Fixes #380
Release Notes:
Types of changes:
Description of the changes being introduced by the pull request:
Fixes the calculation of whether a manifest is a top-level one when the manifest is versioned. Previously, a manifest like 1.root.json would be detected as a delegated manifest because it was 1.root was not in the set of top-level manifests. This now accounts for versioned manifests.
Please verify and check that the pull request fulfills the following requirements: