Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for rollback protection on snapshot, targets, delegations #450

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Jan 23, 2023

Signed-off-by: Asra Ali asraa@google.com

Fixes #286

  • client: adds testing for rollback protection on snapshot, targets, and delegated targets

Relevant: #449

(Testing is already added for timestamp)

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa requested a review from rdimitrov January 23, 2023 16:33
Signed-off-by: Asra Ali <asraa@google.com>
Copy link
Contributor

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Testing the root role for rollback protection was already covered in previous tests, so with this we should have the full set now. Thanks, @asraa 👍

@znewman01 znewman01 merged commit 91c85a0 into theupdateframework:master Jan 24, 2023
znewman01 pushed a commit to znewman01/go-tuf that referenced this pull request May 22, 2023
…ions (theupdateframework#450)

* test: add tests for rollback protection

Signed-off-by: Asra Ali <asraa@google.com>

* golangci-lint

Signed-off-by: Asra Ali <asraa@google.com>

Signed-off-by: Asra Ali <asraa@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: create unit tests for verifying the protection against rollback attacks
3 participants