Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #528 Add-Key to a role #535

Conversation

ChevronTango
Copy link
Contributor

Please fill in the fields below to submit a pull request. The more information that is provided, the better.

Fixes #528

Release Notes: Introduces the add-key command

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please ensure that your PR title is a Conventional Commit breaking change (with a !, as in feat!: change foo).

Description of the changes being introduced by the pull request:
Introduces the add-key command

Please verify and check that the pull request fulfills the following requirements:

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@ChevronTango ChevronTango changed the title feature: #528 Add-Key to a role feat: #528 Add-Key to a role Aug 1, 2023
cmd/tuf/add_key.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kommendorkapten
Copy link
Member

Nice work 🚀
Left some comments that should be fixed.

@ChevronTango
Copy link
Contributor Author

Nice work 🚀 Left some comments that should be fixed.

Brilliant! Thanks for those great spots! Just patched it now so should be ready to go! :)

@kommendorkapten
Copy link
Member

Sorry for not responding to this, been very busy. I will go over your latest changes next week 👍

@ChevronTango ChevronTango force-pushed the 528-support-adding-external-keys branch from 2419f82 to c31d3a2 Compare September 8, 2023 15:53
Introduces the add-key command

Signed-off-by: Edward Brough <edward.brough@gmail.com>
@rdimitrov rdimitrov force-pushed the 528-support-adding-external-keys branch from c31d3a2 to 72ccf94 Compare September 15, 2023 08:39
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
@kommendorkapten kommendorkapten force-pushed the 528-support-adding-external-keys branch from 492f744 to 63f7015 Compare September 15, 2023 11:10
Copy link
Contributor

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ChevronTango! 🚀

@rdimitrov rdimitrov merged commit 70d3a54 into theupdateframework:master Sep 16, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Adding External Keys
3 participants