Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for windows & enable in CI #586

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

kipz
Copy link
Contributor

@kipz kipz commented Jan 29, 2024

Since windows tests were disabled, it looks like we've drifted a bit and introduced a few issues preventing the tests from passing and from the project working on windows:

  • use of unix path separators throughout
  • tests relying on line endings, and Git checkouts being different for windows/linux
  • renaming of files between drives on windows on GitHub Actions
  • renaming of open files (not allowed on windows)

Moved from rdimitrov/go-tuf-metadata#98

EDIT

Signed-off-by: James Carnegie <james.carnegie@docker.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (8391850) 71.43% compared to head (14cda1b) 70.28%.

Files Patch % Lines
metadata/updater/updater.go 22.00% 35 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
- Coverage   71.43%   70.28%   -1.15%     
==========================================
  Files          10       10              
  Lines        2013     2063      +50     
==========================================
+ Hits         1438     1450      +12     
- Misses        463      497      +34     
- Partials      112      116       +4     
Flag Coverage Δ
Go-1.21 70.28% <22.00%> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🪟

@rdimitrov rdimitrov merged commit 9d57731 into theupdateframework:master Jan 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants