Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pin to minor Go versions in go.mod #588

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

rdimitrov
Copy link
Contributor

@rdimitrov rdimitrov commented Jan 30, 2024

I believe we bumped this because of a scanning tool check(govulncheck) that was quite annoying and insisted on upgrading the minor version.

In any case, I think it's better to not enforce other users of the library pin their minor version too just because of us.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@rdimitrov rdimitrov self-assigned this Jan 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@eb347f8). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #588   +/-   ##
=========================================
  Coverage          ?   71.43%           
=========================================
  Files             ?       10           
  Lines             ?     2013           
  Branches          ?        0           
=========================================
  Hits              ?     1438           
  Misses            ?      463           
  Partials          ?      112           
Flag Coverage Δ
Go-1.21 71.43% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rdimitrov rdimitrov merged commit 8391850 into theupdateframework:master Jan 30, 2024
13 checks passed
@rdimitrov rdimitrov deleted the no-minor-go branch January 30, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants