feat: replace logrus in sim with slog #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed the logging was very inconsistent when it comes to using Fatal, Panic, Info, Debug etc. in the current code. Every place that used Fatal or Panic before will now call |
mnm678
previously approved these changes
Mar 7, 2024
|
Resolved the merge conflict |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 70.51% 73.09% +2.57%
==========================================
Files 10 10
Lines 2123 1650 -473
==========================================
- Hits 1497 1206 -291
+ Misses 505 323 -182
Partials 121 121 ☔ View full report in Codecov by Sentry. |
rdimitrov
previously approved these changes
Mar 7, 2024
This removes another thirdparty dependecy without sacrificing any functionality. Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
rdimitrov
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #609