Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multirepo potential nil pointer dereference #658

Merged

Conversation

MrDan4es
Copy link
Contributor

This PR prevent potential panic on NIL pointer when we trying to download file (from user input repo name for example).

@MrDan4es MrDan4es requested a review from a team as a code owner November 20, 2024 10:10
@kommendorkapten
Copy link
Member

Thanks for fixing this. Would you mind amend the commit with a signoff?

@MrDan4es
Copy link
Contributor Author

Done

Signed-off-by: mrdan4es <mrdan4es@gmail.com>
Copy link
Contributor

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice! 🙌 Thank you 🚀

Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kommendorkapten kommendorkapten merged commit 990cdb8 into theupdateframework:master Nov 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants