-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
review/document client exceptions #1312
Comments
Temporary disable (inline) try-except-raise and broad-except warnings until client exception handling is revised (theupdateframework#1312). Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
Temporary disable (inline) try-except-raise and broad-except warnings until client exception handling is revised (theupdateframework#1312). Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
Temporary disable (inline) try-except-raise and broad-except warnings until client exception handling is revised (theupdateframework#1312). Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
Temporary disable (inline) try-except-raise and broad-except warnings in the new Updater code until client exception handling is revised (theupdateframework#1312). Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
The major items here are probably:
|
After doing the metadata bundle integration, I think our client exceptions should be grouped like this:
|
My impression is that ngclient exceptions are in a pretty good state by now, but review would be good:
In addition to a review, we should document how ngclient uses exceptions: mostly that RepositoryError is used as a catch all for fatal update errors -- a metadata state that clients cannot recover from, but where a later update (after the remote updates metadata) might succeed. |
Updated title: I think we're mostly missing proper documentation:
|
Description of issue or feature request:
Revise and implements client exceptions handling
Current behavior:
Not all thrown exceptions are documented or handled by the client.
Expected behavior:
Implement proper exception handling and document the API
Sync with #1131
The text was updated successfully, but these errors were encountered: