Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's not use pre-release versions of tools in tox environments #1350

Closed
jku opened this issue Apr 14, 2021 · 1 comment · Fixed by #1364
Closed

Let's not use pre-release versions of tools in tox environments #1350

jku opened this issue Apr 14, 2021 · 1 comment · Fixed by #1364
Labels
testing

Comments

@jku
Copy link
Member

jku commented Apr 14, 2021

We do pip install --pre ... in tox.ini. This means our testing tools like coverage, black, isort etc (and I suppose their dependencies) may be pre-releases.

This has been the case since 2015 but it sounds like a bad idea. Should we drop the --pre?
@jku jku added the testing label Apr 14, 2021
@joshuagl
Copy link
Member

If we don't have a good reason to keep it, or don't know what the good reason was, I vote we drop use of --pre

@jku jku changed the title Should we use pre-releases in tox environments? Let's not use pre-release versions of tools in tox environments Apr 27, 2021
jku pushed a commit to jku/python-tuf that referenced this issue Apr 27, 2021
tox: Don't use pre-release tools
aaca8ec 
Keep using newest versions of build tools, but don't use pre-releases:
* less downloading (with chances of failures) happens in the CI because
  versions change less often
* tools are less likely to break the build (or at least it happens less
  often)

This change should not affect the software under test as we install
pinned versions of those.

Note that this also doesn't affect black: tox still ends up with a
pre-release version of black because that project has never made an
actual release.

Fixes theupdateframework#1350

Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
@jku jku mentioned this issue Apr 27, 2021
Merged
@jku jku closed this as completed in #1364 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tox: Don't use pre-release tools jku/python-tuf
2 participants
@jku @joshuagl