repo.py: Decode key bytes for SHA key as well #1066

jku · 2020-07-03T08:51:49Z

key bytes were decoded as utf-8 for the JSON keys. Do the same for SHA
key bytes.

Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com

Please verify and check that the pull request fulfills the following
requirements:

The code follows the Code Style Guidelines
Tests have been added for the bug fix or new feature -- repo.py isn't tested: I don't think I'm adding tests just for this

key bytes were decoded as utf-8 for the JSON keys. Do the same for SHA key bytes. Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>

lukpueh · 2020-07-03T08:54:08Z

Thanks for the patch, @jku! Please see #881 for context about cli tools.

joshuagl

Thanks for the patch @jku. Good to merge this and have the tools working whilst their futures is decided in #881

repo.py: Decode key bytes for SHA key as well

e662f4f

key bytes were decoded as utf-8 for the JSON keys. Do the same for SHA key bytes. Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>

joshuagl approved these changes Jul 6, 2020

View reviewed changes

joshuagl merged commit cdb3556 into theupdateframework:develop Jul 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repo.py: Decode key bytes for SHA key as well #1066

repo.py: Decode key bytes for SHA key as well #1066

jku commented Jul 3, 2020 •

edited

Loading

lukpueh commented Jul 3, 2020

joshuagl left a comment

repo.py: Decode key bytes for SHA key as well #1066

repo.py: Decode key bytes for SHA key as well #1066

Conversation

jku commented Jul 3, 2020 • edited Loading

lukpueh commented Jul 3, 2020

joshuagl left a comment

Choose a reason for hiding this comment

jku commented Jul 3, 2020 •

edited

Loading