-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new blog post about the signer API #2276
Conversation
I think the easiest way to review is to read https://github.com/jku/python-tuf/blob/securesystemslib-blog/docs/_posts/2023-01-24-securesystemslib-signer-api.md -- only the header block is unhandled, otherwise it should look like the published post |
Pull Request Test Coverage Report for Build 4013939676
💛 - Coveralls |
CC @VickyMerzOwn: you mentioned you might be interested in reviewing |
f04fbc9
to
abe96dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool post! I left two suggestions inline (feel free to ignore). Did you consider adding a third code example that showcases dynamic dispatch for public key and verification?
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
abe96dc
to
388768d
Compare
Amended the commit with the two minor suggestions: both clarify that private key URIs are constructed while public keys are imported from the underlying signing system. |
I did... Since the application code looks exactly what it looked like before, it's not that interesting. We of course know that the dispatch will enable GPG or sigstore keys but that's not really visible right now |
This gives some example application code for the new securesystemslib.signer API.