Fix try-except-else in test_updater.py #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntax/understanding. Signed-off-by: Sebastien Awwad <sebastien.awwad@gmail.com>
awwad
force-pushed
the
fix_try_except_else_in_tests
branch
from
709c635 to
2c1ca1e
Compare
|
Rebased after merge of #842. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some silly holes in the try-except clauses in some tests expecting NoWorkingMirrorError, and some other errors. The cases would have passed if no errors were raised.... This patches those holes in logic.
Merge #842 first. That included two of these.....