Fix failing builds due to pylint 2.4.0 update #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to be an artifact of a feature-removal (compression) in 8de5c69. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Pylint now has a "redeclared-assigned-name" check that gets triggered if we re-use our custom "junk" unused var name. It does not if we use the "_" default unused var name. So let's use "_" then. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
adityasaky
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
None.
Description of the changes being introduced by the pull request:
Pylint was updated to 2.4.0 a few minutes ago. The new versions now emits the following warnings:
This PR fixes the issues. See commit messages for details.
Please verify and check that the pull request fulfills the following
requirements: