Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/test-repository fails if both "compare_source" and initial root are set #345

Closed
jku opened this issue May 22, 2024 · 1 comment · Fixed by #346
Closed

actions/test-repository fails if both "compare_source" and initial root are set #345

jku opened this issue May 22, 2024 · 1 comment · Fixed by #346
Assignees
Labels
bug Something isn't working

Comments

@jku
Copy link
Member

jku commented May 22, 2024

Setting compare_source=True in test-repository actions leads to a actions/checkout in the root dir which on github means cleaning out that directory

This means the root.json file that may have been there will not be found

@jku jku added the bug Something isn't working label May 22, 2024
@jku jku self-assigned this May 22, 2024
@jku
Copy link
Member Author

jku commented May 22, 2024

a quick fix is likely to set clean: False in the actions/checkout call...

jku added a commit to jku/tuf-on-ci that referenced this issue May 22, 2024
Previously setting the initial root would only work if compare_source
was False (because compare_source would lead to a checkout that would
clean the initial root.json that had been put into working dir).

* Change tuf-on-ci-test-client so that --compare-source has an argument
  (the metadata directory to compare against)
* Checkout into a subdirectory: this allows root.json to exist in
  workdir
* Pass the metadata directory to tuf-on-ci-test-client --compare-source

This changes tuf-on-ci-test-client CLI but does not change the action
API so existing users are fine.

Fixes theupdateframework#345
@jku jku closed this as completed in #346 May 22, 2024
jku added a commit that referenced this issue May 22, 2024
Previously setting the initial root would only work if compare_source
was False (because compare_source would lead to a checkout that would
clean the initial root.json that had been put into working dir).

* Change tuf-on-ci-test-client so that --compare-source has an argument
  (the metadata directory to compare against)
* Checkout into a subdirectory: this allows root.json to exist in
  workdir
* Pass the metadata directory to tuf-on-ci-test-client --compare-source

This changes tuf-on-ci-test-client CLI but does not change the action
API so existing users are fine.

Fixes #345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant