Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock changes: remove pin state and switch colors to high-contrast #49

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Clock changes: remove pin state and switch colors to high-contrast #49

merged 3 commits into from
Dec 15, 2023

Conversation

lgarron
Copy link
Member

@lgarron lgarron commented Dec 15, 2023 •
edited
Loading

This supports the 2024 Regulations: https://www.worldcubeassociation.org/posts/wca-regulations-january-2024

  • Ignore final pin state during scrambles and draw pins as faint dots.
  • Change the color scheme to high-contrast. This makes the state easier to see and matches more modern speedsolving clocks, although I've kept the tones blue as a nod to the original clock colors.
  • Reduce the clock face stroke width (it's not as needed for high-contrast) and emphasize the 12 o'clock position to provide an orientation cue.

Example:
clock24

Real-world black-and-white printout:
IMG_8455

@lgarron lgarron force-pushed the clock-2024 branch 2 times, most recently from dc1e392 to 6eb87cc Compare December 15, 2023 08:24
@lgarron lgarron changed the title Implement clock changes for 2024 Clock changes: remove pin state and switch colors to high-contrast Dec 15, 2023
jfly
jfly approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work =)

scrambles/src/main/java/org/worldcubeassociation/tnoodle/puzzle/ClockPuzzle.java Outdated Show resolved Hide resolved
scrambles/src/main/java/org/worldcubeassociation/tnoodle/puzzle/ClockPuzzle.java Outdated Show resolved Hide resolved
@lgarron @jfly
Apply suggestions from code review
c5d5597 
Co-authored-by: Jeremy Fleischman <jeremyfleischman@gmail.com>
@gregorbg gregorbg mentioned this pull request Dec 15, 2023
Closed
gregorbg
gregorbg approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@gregorbg gregorbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for delivering these well in time for the Jan 1 publication :)

@gregorbg gregorbg merged commit ebd3622 into master Dec 15, 2023
2 checks passed
@lgarron lgarron deleted the clock-2024 branch December 15, 2023 18:35
lgarron added a commit to cubing/cubing.js that referenced this pull request Dec 21, 2023
@lgarron
v0.43.11
d011aa3 
Release notes:

- [twisty] `<twizzle-link>`: Keep the clipboard icon in the same place while showing status icons.
- Clock colors: ignore pin state and udpate colors. See thewca/tnoodle-lib#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfly jfly jfly approved these changes

@gregorbg gregorbg gregorbg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgarron @jfly @gregorbg