Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links for some documents #376

Closed
Nanush7 opened this issue Feb 25, 2024 · 8 comments · Fixed by #378
Closed

Broken links for some documents #376

Nanush7 opened this issue Feb 25, 2024 · 8 comments · Fixed by #378
Assignees

Comments

@Nanush7
Copy link
Member

Nanush7 commented Feb 25, 2024

wca{...} is always replaced with the www subdomain, but in some cases it needs to be replaced with the documents subdomain. Maybe the script can check if the url includes "documents/" and then decide which one to use? (this way we don't need to change every single file where wca{...} is used).

The list of files using this shortcut:

$ grep -R --files-with-matches "wca{"
./documents-guide.md
./bin/build.sh
./README.md
./documents/motions/10.2021.6 - Financial Committee.md
./documents/motions/07.2021.1 - Registered Speedcubers.md
./documents/motions/01.2021.1 - Spirit.md
./documents/motions/04.2022.1 - WCA Board.md
./documents/motions/10.2021.2 - Competition Announcement Team.md
./documents/motions/19.2021.1 - Regulations and Guidelines.md
./documents/motions/10.2021.9 - Regulations Committee.md
./documents/motions/10.2022.3 - Disciplinary Committee.md
./documents/policies/external/Competition Requirements.md
./documents/policies/external/Logo Usage.md
./documents/Code of Ethics.md
@dmint789
Copy link
Member

dmint789 commented Mar 6, 2024

What do you mean by the documents subdomain?

@dmint789
Copy link
Member

dmint789 commented Mar 6, 2024

Is there really a documents.worldcubeassociation.org?

@Nanush7
Copy link
Member Author

Nanush7 commented Mar 6, 2024

@dmint789
Copy link
Member

dmint789 commented Mar 6, 2024

@Nanush7 the link works for me though

@Nanush7
Copy link
Member Author

Nanush7 commented Mar 6, 2024

Which one?

@dmint789
Copy link
Member

dmint789 commented Mar 6, 2024

@Nanush7 the one you just sent for the WSAP

@Nanush7
Copy link
Member Author

Nanush7 commented Mar 6, 2024

Yeah, the www doesn't work anymore for documents.

@dmint789
Copy link
Member

dmint789 commented Mar 6, 2024

Oh, I thought you were sharing a link that IS broken. Yeah, this needs to be fixed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants