Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delegate Handbook #379

Merged
merged 21 commits into from
Jun 23, 2024
Merged

Add Delegate Handbook #379

merged 21 commits into from
Jun 23, 2024

Conversation

nsilvestri
Copy link
Member

This commit adds the Delegate Handbook to the documents repo. The Delegate Crash Course will be deleted in a future update to make sure that it is around while the website is still linking to it.

@nsilvestri nsilvestri force-pushed the delegate-handbook branch 3 times, most recently from 68e1814 to 402f7e9 Compare March 25, 2024 22:08
Copy link
Member

@dmint789 dmint789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a review

edudoc/delegate-handbook/delegate-handbook.md Outdated Show resolved Hide resolved
edudoc/delegate-handbook/delegate-handbook.md Outdated Show resolved Hide resolved
@nsilvestri nsilvestri marked this pull request as ready for review May 10, 2024 05:03
@nsilvestri nsilvestri requested review from a team as code owners May 10, 2024 05:03
@nsilvestri nsilvestri requested a review from dmint789 May 10, 2024 05:03
dmint789
dmint789 previously approved these changes May 10, 2024
@dmint789
Copy link
Member

@nsilvestri can you set the PR back to draft mode?

@nsilvestri nsilvestri marked this pull request as draft May 10, 2024 05:36
@dmint789
Copy link
Member

@nsilvestri can you add the source file for the extra decision tree to editable image files? You might need to merge the master branch into yours, cause it seems like the base of this branch is out of date.

@nsilvestri
Copy link
Member Author

@dmint789 done

@dmint789
Copy link
Member

Fixed/changed some images. Replaced references to competitor profiles with mock images. Fixed links in the table of contents.

@dmint789
Copy link
Member

@gregorbg why does this say a WST review will be required?

@gregorbg
Copy link
Member

Because the CODEOWNERS file marks us as owners of the whole repository, ie all changes have to be reviewed by WST

@dmint789
Copy link
Member

Does that mean a WST review is required even when we only change stuff in the directories the WQAC owns? I don't remember this being the case before

@nsilvestri nsilvestri marked this pull request as ready for review June 23, 2024 20:35
@nsilvestri nsilvestri requested a review from dmint789 June 23, 2024 20:35
@nsilvestri nsilvestri self-assigned this Jun 23, 2024
Copy link
Member

@dmint789 dmint789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nsilvestri nsilvestri merged commit 965413f into master Jun 23, 2024
1 check passed
@nsilvestri nsilvestri deleted the delegate-handbook branch June 23, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants