-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Delegate Handbook #379
Conversation
68e1814
to
402f7e9
Compare
402f7e9
to
5028b64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a review
@nsilvestri can you set the PR back to draft mode? |
@nsilvestri can you add the source file for the extra decision tree to editable image files? You might need to merge the master branch into yours, cause it seems like the base of this branch is out of date. |
@dmint789 done |
Fixed/changed some images. Replaced references to competitor profiles with mock images. Fixed links in the table of contents. |
@gregorbg why does this say a WST review will be required? |
Because the CODEOWNERS file marks us as owners of the whole repository, ie all changes have to be reviewed by WST |
Does that mean a WST review is required even when we only change stuff in the directories the WQAC owns? I don't remember this being the case before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This commit adds the Delegate Handbook to the documents repo. The Delegate Crash Course will be deleted in a future update to make sure that it is around while the website is still linking to it.